Extract the connection monitor from the connection manager #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
May 11, 2021
fabianfett
reviewed
May 11, 2021
glbrntt
force-pushed
the
gb-connection-manager-delegate
branch
3 times, most recently
from
66ec32e to
afdc96c
Compare
Motivation: The connection monitor allows users to register a delegate for changes in connectivity state as well as access the current state. Because the user code may call out it is executed on a `DispatchQueue` (rather than the connection's `EventLoop`). However, there are cases within gRPC where state change notifications on the event loop are very useful (such as in a pool of connection managers all running on the same event loop). Moreover, it's not necessary for the connection manager to hold the connection monitor, it just needs a way to inform it about any changes so that it can call any user provided delegates. Modifications: - Extract the connectivity monitor from the connection manager - Allow on-event-loop callbacks to be passed to the connection manager for connection state changes and for certain HTTP/2 events (stream closed and receiving max concurrent streams settings). While not strictly necessary for this change they will be helpful down the line. - Update a bunch of tests. Result: The connection manager no longer holds a connection monitor and may execute state change callbacks on the event loop.
glbrntt
force-pushed
the
gb-connection-manager-delegate
branch
from
afdc96c to
72b4b61
Compare
fabianfett
approved these changes
May 12, 2021
| @@ -1025,6 +1012,106 @@ extension ConnectionManagerTests { | |||
| XCTAssertNoThrow(try shutdown.wait()) | |||
| } | |||
| } | |||
|
|
|||
| func testHTTP2Delegates() throws { | |||
There was a problem hiding this comment.
Nit: do we need the throws here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The connection monitor allows users to register a delegate for changes
in connectivity state as well as access the current state. Because the
user code may call out it is executed on a
DispatchQueue(rather thanthe connection's
EventLoop).However, there are cases within gRPC where state change notifications
on the event loop are very useful (such as in a pool of connection
managers all running on the same event loop).
Moreover, it's not necessary for the connection manager to hold the
connection monitor, it just needs a way to inform it about any changes
so that it can call any user provided delegates.
Modifications:
for connection state changes and for certain HTTP/2 events (stream
closed and receiving max concurrent streams settings). While not
strictly necessary for this change they will be helpful down the line.
Result:
The connection manager no longer holds a connection monitor and may
execute state change callbacks on the event loop.