Use PlatformSupport.makeEventLoopGroup on BasicTutorial
#1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @e-sung -- I think that's a good idea, would you mind updating the client code as well (https://github.com/grpc/grpc-swift/blob/main/Sources/Examples/RouteGuide/Client/main.swift)? Also you'll need to sign the CLA before we can accept any contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though Apple Platform documentation is suggesting to use
PlatformSupport.makeEventLoopGroupwhere possible, I'm afraid it may not be obvious for beginners to checkout that documentation.I think it would be better if we use
PlatformSupport.makeEventLoopGroupAPI in Basic-Tutorial document which is much more approachable.How do you think about this idea?