Make 'NIOSSLContext' ahead of time #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A `NIOSSLContext` may be used for multiple connections. Moreover, creating `NIOSSLContext`s is _expensive_ and we should avoid creating them unnecessarily. At the moment we create one context per connection for the client and the server. Modifications: - Make `NIOSSLContext`s when setting up the client (rather than when initializing a channel). - Make `NIOSSLContext`s when preparing a server bootstrap Result: - We only create `NIOSSLContext` once per server/client connection
Lukasa
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A
NIOSSLContextmay be used for multiple connections. Moreover,creating
NIOSSLContexts is expensive and we should avoid creatingthem unnecessarily. At the moment we create one context per connection
for the client and the server.
Modifications:
NIOSSLContexts when setting up the client (rather than wheninitializing a channel).
NIOSSLContexts when preparing a server bootstrapResult:
NIOSSLContextonce per server/client connection