Write alloc counter test output to stdout and file #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The allocation counting test harness writes output to a file and then parses the file to check for allocations. However, this step includes building a whole bunch of stuff which can take some time and since no output is generated during that time it appears to some CI systems as if there is no forward progress. Travis will kill CI jobs if there is no output for 10 minutes. Modifications: - 'tee' the output from running the allocation counting tests Result: We see progress on stdout.
Lukasa
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The allocation counting test harness writes output to a file and then
parses the file to check for allocations. However, this step includes
building a whole bunch of stuff which can take some time and since no
output is generated during that time it appears to some CI systems as if
there is no forward progress. Travis will kill CI jobs if there is no
output for 10 minutes.
Modifications:
Result:
We see progress on stdout.