Provide 'default' static functions for making client/server configuration #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Motivation: The `ClientConnection` and `Server` configuration objects are reasonably large and contain many deafult initialized fields. Whenever we add a field we need to add a new initializer and deprecate the old one in order to not break API. Providing a static 'default' function which only accepts the required properties allows us to add defaulted values without doing the deprecate and replace. Modifications: - Add `default` methods to `ClientConnection.Configuration` and `Server.Configuration` - Deprecate `init`s. Result: Easier to add new fields in the future.
Lukasa
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
ClientConnectionandServerconfiguration objects are reasonablylarge and contain many deafult initialized fields. Whenever we add a
field we need to add a new initializer and deprecate the old one in
order to not break API. Providing a static 'default' function which only
accepts the required properties allows us to add defaulted values without
doing the deprecate and replace.
Modifications:
defaultmethods toClientConnection.ConfigurationandServer.Configurationinits.Result:
Easier to add new fields in the future.