Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend interoperability tests to use async provider #1312

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

simonjbeaumont
Copy link
Collaborator

The interoperability tests exercise a well-defined sequence of requests
for all implementations of gRPC. We already had interop tests for the
ELG-based client and provider. This pull request extends the tests to
exercise an async-await–based provider.

The interoperability tests exercise a well-defined sequence of requests
for all implementations of gRPC. We already had interop tests for the
ELG-based client and provider. This pull request extends the tests to
exercise an async-await–based provider.
///
/// See: https://github.com/grpc/grpc/blob/master/doc/interop-test-descriptions.md#server
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
public class TestServiceAsyncProvider: Grpc_Testing_TestServiceAsyncProvider {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this class attempts to be be a like-for-like translation of TestServiceProvider.

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Nov 15, 2021
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but looks great otherwise, thanks Si!

Signed-off-by: Si Beaumont <[email protected]>
@glbrntt glbrntt merged commit 2a496d9 into grpc:async-await Nov 15, 2021
glbrntt pushed a commit that referenced this pull request Nov 26, 2021
The interoperability tests exercise a well-defined sequence of requests
for all implementations of gRPC. We already had interop tests for the
ELG-based client and provider. This pull request extends the tests to
exercise an async-await–based provider.

Signed-off-by: Si Beaumont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants