Allow end stream to be dropped in the async server handler #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The async server handler throws an error if the end-of-stream received from the client is dropped. The end-of-stream will only be dropped if the request stream has already been finished. This happens in a few cases: either end-of-stream has already been received, or as a side effect of the task running the user handler completing. The latter case is possible of the user handler does not wait for end of stream (if it encounters an error, for example). This happened periodically in some tests as a result of the user handler completing and receiving end-stream racing. Modifications: - Tolerate dropping end stream in the async server handler. Result: Fewer flakey tests.
fabianfett
approved these changes
Dec 9, 2021
Lukasa
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The async server handler throws an error if the end-of-stream received
from the client is dropped. The end-of-stream will only be dropped if
the request stream has already been finished. This happens in a few
cases: either end-of-stream has already been received, or as a side
effect of the task running the user handler completing.
The latter case is possible of the user handler does not wait for end of
stream (if it encounters an error, for example). This happened
periodically in some tests as a result of the user handler completing
and receiving end-stream racing.
Modifications:
Result:
Fewer flakey tests.