Update allocation counter limits #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A recent NIO release reduced allocations which has thrown off our expected counts. Modifications: Update allocation limits. Result: Limits are more appropriate.
FranzBusch
reviewed
Jan 27, 2022
.github/workflows/ci.yaml
Outdated
| MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 504000 | ||
| MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 504001 |
There was a problem hiding this comment.
In your PR description, you wrote that a recent PR in NIO reduced allocations, but this is increasing the limits. Or am I missing something?
There was a problem hiding this comment.
Yup, this was a no-op change to get the CI to run so we can extract the new limits (hence this is a draft).
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Jan 27, 2022
Motivation: A recent NIO release reduced allocations which has thrown off our expected counts. Modifications: Update allocation limits. Result: Limits are more appropriate. (cherry picked from commit 4dc17a8)
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Jan 27, 2022
Motivation: A recent NIO release reduced allocations which has thrown off our expected counts. Modifications: Update allocation limits. Result: Limits are more appropriate. (cherry picked from commit 4dc17a8)
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Feb 28, 2022
Motivation: A recent NIO release reduced allocations which has thrown off our expected counts. Modifications: Update allocation limits. Result: Limits are more appropriate. (cherry picked from commit 4dc17a8)
glbrntt
added a commit
that referenced
this pull request
Feb 28, 2022
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Jun 17, 2022
Motivation: A recent NIO release reduced allocations which has thrown off our expected counts. Modifications: Update allocation limits. Result: Limits are more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A recent NIO release reduced allocations which has thrown off our
expected counts.
Modifications:
Update allocation limits.
Result:
Limits are more appropriate.