Add more flexibility to perf tests #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's useful to run the perf tests in different configurations, e.g. to compare NIOTS with NIOPosix or to measure the affect of using TLS. Modifications: Add two options to the perf test suite: - `--use-nio-transport-services`: uses a NIOTS event loop group if available on the host platform and, - `--use-tls`: uses TLS if the test runs both a client and server Also exposes a `--repeats` option. Result: Tests are more flexible.
Lukasa
approved these changes
Feb 7, 2022
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Jun 17, 2022
Motivation: It's useful to run the perf tests in different configurations, e.g. to compare NIOTS with NIOPosix or to measure the affect of using TLS. Modifications: Add two options to the perf test suite: - `--use-nio-transport-services`: uses a NIOTS event loop group if available on the host platform and, - `--use-tls`: uses TLS if the test runs both a client and server Also exposes a `--repeats` option. Result: Tests are more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's useful to run the perf tests in different configurations, e.g. to
compare NIOTS with NIOPosix or to measure the affect of using TLS.
Modifications:
Add two options to the perf test suite:
--use-nio-transport-services: uses a NIOTS event loop group ifavailable on the host platform and,
--use-tls: uses TLS if the test runs both a client and serverAlso exposes a
--repeatsoption.Result:
Tests are more flexible.