Remove perf tests for 5.2 #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The performance tests have recently become quite unstable for 5.2 and require a few runs to pass. While we could broaden the slack allowed or investigate further, it doesn't seem worth it: NIO will drop support for 5.2 when 5.6 is released at which point we'll have to do the same. Modifications: - Remove the allocation counting tests for Swift 5.2 Result: - 5.2 performance is no longer monitored - CI is less flaky.
FranzBusch
approved these changes
Feb 7, 2022
Lukasa
approved these changes
Feb 7, 2022
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Jun 17, 2022
Motivation: The performance tests have recently become quite unstable for 5.2 and require a few runs to pass. While we could broaden the slack allowed or investigate further, it doesn't seem worth it: NIO will drop support for 5.2 when 5.6 is released at which point we'll have to do the same. Modifications: - Remove the allocation counting tests for Swift 5.2 Result: - 5.2 performance is no longer monitored - CI is less flaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The performance tests have recently become quite unstable for 5.2
and require a few runs to pass. While we could broaden the slack allowed
or investigate further, it doesn't seem worth it: NIO will drop support
for 5.2 when 5.6 is released at which point we'll have to do the same.
Modifications:
Result: