ConnectionPool Waiter should store its timeout task #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Connection pool waiters have a scheduled tasks for to timeout waiting. This is cancelled and set to `nil` when the waiter is succeeded or failed. Hoever, when scheduling a task the task was never stored! This would lead to the potentially firing when the deadline expired although the effect of this would be a no-op. Modifications: - Capture the waiters scheduled task - Add a test Result: Cancelled tasks are actually cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Connection pool waiters have a scheduled tasks for to timeout waiting.
This is cancelled and set to
nilwhen the waiter is succeeded orfailed. Hoever, when scheduling a task the task was never stored! This
would lead to the potentially firing when the deadline expired although
the effect of this would be a no-op.
Modifications:
Result:
Cancelled tasks are actually cancelled.