Create a first version of a Podspec that seems to be working #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks, this is huge! I think using SwiftGRPC for the module name is appropriate - it's also consistent with SwiftProtobuf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for me, this Podspec is working. Also, as long as the podspec is called
Podspec-incomplete.swift, runningpod installfails right away, so I think using the proper name makes sense already, for those who'd like to try it out. See #111 (comment) on how to use the Podspec for now.What still needs to be done, though, is changing the resulting module name, while currently the generated code imports
gRPC(also see #111 (comment)). I would actually suggest always usingSwiftGRPCas the name for this project's module, instead ofgRPC, to avoid confusion withgRPC-Core(which gets built asgRPCas well). WDYT?