Re-enable 5.6 tests #1390
Merged
Re-enable 5.6 tests #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: https://bugs.swift.org/browse/SR-15955 precluded tests from running on Swift 5.6. This has been resolved in Swift 5.6.1. Modifications: - Re-enable tests on 5.6 - Disable TSAN on 5.6 (the tests for AsyncServerHandler are abusing `EmbeddedChannel`; the tests will be rewritten when the handler state machine is rewritten and the AsyncEmbeddedChannel comes to fruition) Result: Tests run on 5.6
glbrntt
force-pushed
the
gb-enable-5.6-tests
branch
from
83e0aeb to
ae93175
Compare
FranzBusch
approved these changes
Apr 20, 2022
Lukasa
approved these changes
Apr 20, 2022
This reverts commit 91b0df4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
https://bugs.swift.org/browse/SR-15955 precluded tests from running on
Swift 5.6. This has been resolved in Swift 5.6.1.
Modifications:
Result:
Tests run on 5.6