-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all tests discoverable on Linux #1399
Conversation
Motivation: Test discovery on Linux relies on source code analysis. Tests in subclasses which do not explicitly redeclare each test are missed. As a result, a number of tests are not run on Linux. Modifications: - Explicitly redeclare tests in subclasses. Result: - Resolves grpc#1392
I diffed the output of I was hoping we might be able to use |
OOI, what's going to stop this from diverging when a new test is added to the base class? Do you think it's worth adding a CI check for the diff you performed manually for this PR? |
I'm +1 with @simonjbeaumont: I'd love to see a tool written for this that we can reuse on our other repos. |
Oh I totally agree, a tool would be great and that's what I looked at doing first:
If you have any other ideas I'm all ears! |
One option is parsing all the test files and attempting to build up a graph of test classes and analysing them that way. Not ideal but probably workable. |
This reverts commit 555b004.
Motivation: Test discovery on Linux relies on source code analysis. Tests in subclasses which do not explicitly redeclare each test are missed. As a result, a number of tests are not run on Linux. Modifications: - Explicitly redeclare tests in subclasses. Result: - Resolves grpc#1392
Motivation:
Test discovery on Linux relies on source code analysis. Tests in
subclasses which do not explicitly redeclare each test are missed. As a
result, a number of tests are not run on Linux.
Modifications:
Result: