Suspend request stream writes before the RPC is ready #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Writes on the request stream should suspend before the RPC is ready. That's not the case right now. Modifications: - Allow the writability of a request stream writer to be specified when initialized and have clients default to not writable. - Plumb through an `onStart` callback which is triggered on the `channelActive` of the HTTP/2 stream which toggles the writability. Result: Attempting to write on a request stream before the underlying http/2 stream is ready will suspend.
Lukasa
approved these changes
May 25, 2022
fabianfett
reviewed
May 25, 2022
| try self.pool.close().wait() | ||
| self.pool = nil | ||
| if self.pool != nil { | ||
| try self.pool.close().wait() |
There was a problem hiding this comment.
Is there an async equivalent for this?
| try self.server.close().wait() | ||
| self.server = nil | ||
| if self.server != nil { | ||
| try self.server.close().wait() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Writes on the request stream should suspend before the RPC is ready.
That's not the case right now.
Modifications:
initialized and have clients default to not writable.
onStartcallback which is triggered on thechannelActiveof the HTTP/2 stream which toggles the writability.Result:
Attempting to write on a request stream before the underlying http/2
stream is ready will suspend.