Update PCAP example to be async #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Our examples should at least attempt to be up-to-date. The PCAP example currenly uses the NIO based API, we should switch it to the async API. Modifications: - Update the PCAP example to use async/await - Ditch logging for print Result: PCAP example is async/await
FranzBusch
approved these changes
Jun 1, 2022
|
|
||
| // Ensure that we close the file sink when we're done with it. | ||
| defer { | ||
| try? fileSink.syncClose() |
There was a problem hiding this comment.
Why are we ? and ! in the above defer?
There was a problem hiding this comment.
No particular reason.
glbrntt
commented
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our examples should at least attempt to be up-to-date. The PCAP example
currenly uses the NIO based API, we should switch it to the async API.
Modifications:
main.swifttoPacketCapture.swiftResult:
PCAP example is async/await