Fix no output when Client=False,TestClient=True #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severnt
force-pushed
the
fix-generate-test-clients
branch
from
fab82d0 to
f030f5a
Compare
glbrntt
requested changes
Jan 22, 2024
| @@ -156,7 +156,7 @@ func main(args: [String]) throws { | |||
| binaryFile.content = serializedFileDescriptorProto | |||
| response.file.append(binaryFile) | |||
| } | |||
| if !fileDescriptor.services.isEmpty && (options.generateClient || options.generateServer) { | |||
| if !fileDescriptor.services.isEmpty && (options.generateClient || options.generateServer || options.generateTestClient) { | |||
There was a problem hiding this comment.
Oh sorry, the formatter doesn't like this, could you run ./scripts/format.sh -f?
There was a problem hiding this comment.
Looks like the formatter script isn't happy with -f.. I'll put up a separate PR for that.
There was a problem hiding this comment.
Ah, right, -f isn't required but the script tells you to pass it 🙈
severnt
force-pushed
the
fix-generate-test-clients
branch
from
062b4c7 to
0fb60da
Compare
glbrntt
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until 1.19.0, passing
Client=FalseandTestClient=Truewould result in a file being generated. After commit 09c46b0 - this no longer happens.