Remove GRPCLogger #1853
Merged
Remove GRPCLogger #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: GRPCLogger was added so that the source of logs was always set to 'GRPC'. This was done because swift-log would set it to the parent directory of the source file assuming it would be the module which isn't always the case. This was fixed some time ago in swift-log making GRPCLogger redundant. Modifications: - Remove GRPCLogger Result: Less code
gjcairo
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
GRPCLogger was added so that the source of logs was always set to 'GRPC'. This was done because swift-log would set it to the parent directory of the source file assuming it would be the module which isn't always the case. This was fixed some time ago in swift-log making GRPCLogger redundant.
Modifications:
Result:
Less code