-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lock deps to exact versions #289
Conversation
I think I would prefer to only version-lock the packages that need it, and only as much as needed. So for now, I would only lock Let me know if you think differently. |
@MrMage I think the most important thing is to ensure that grpc protoc plugin is used with the same version of swift grpc and swift protobuf. Currently this is how it looks: https://github.com/grpc/grpc-swift/blob/master/SwiftGRPC.podspec#L44 In podspec version is In https://github.com/grpc/grpc-swift/blob/master/Package.swift#L21 version is Since apple swift protobuf do not follow semver even having |
Do you have any documentation on SwiftProtobuf‘s versioning? Haven’t been broken by revisions since 0.9, and i wouldn’t expect the 1.0 minor to receive any breaking changes in the future given that 1.1 is already out, but it might still receive bug fixes. Also, if you desire consistency with the CocoaPods, we could use `.upToNextMinor(from: "1.0.3")’? The end result will be the same anyway. |
I don't have any documentation, but if you look:
If upToNextMinor(from: "1.0.3") is updates to 1.1.1 version then it's not good, otherwise you can make your changes and close this PR. Thanks 👍 |
upToNextMinor should always stay below 1.1, so it should work. Why not just try it? |
Yes it works, I updated PR. Now swift protobuf is both 1.0.3 in code generation and pod library. |
We should issue a new release which includes grpc/grpc-swift#289 (the fix for grpc/grpc-swift#288).
We should issue a new release which includes grpc/grpc-swift#289 (the fix for grpc/grpc-swift#288).
fixes #288