Several fixes to the example projects. #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a `try!` in Examples/Cocoapods/NaturalLanguage/NaturalLanguage/AppDelegate.swift - Ran `pod install` in Examples/Cocoapods/NaturalLange, causing a minor update to that project - Removed existing references to SwiftProtobuf and SwiftGRPC from EchoXcode.xcodeproj (the user should add these manually) - Removed existing references to SwiftGRPC from SimpleXcode.xcodeproj (the user should add these manually) - Removed CocoaPods references from SimpleXcode.xcodeproj (that project isn't using CocoaPods) - Updated READMEs I am afraid the "Google" samples are still broken because of a compiler error in https://github.com/swift-server/http (might be new with Swift 4.2).
rebello95
approved these changes
Aug 28, 2018
timburks
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try!in Examples/Cocoapods/NaturalLanguage/NaturalLanguage/AppDelegate.swiftpod installin Examples/Cocoapods/NaturalLange, causing a minor update to that projectI am afraid the "Google" samples are still broken because of a compiler error in https://github.com/swift-server/http (might be new with Swift 4.2).