Replace absolute path in generated xcodeproj #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishkawa
changed the title
MrMage
approved these changes
Sep 18, 2018
There was a problem hiding this comment.
This is great, thanks! I had similar problems in the past.
However, I think this will apply to all other module maps as well. Do you think it would be possible to run the same transformations for all other module maps and commit them into the repository as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #307, I accidentally inserted some absolute paths of my local machine, which start with
/Users/ishkawa, intoSwiftGRPC-Carthage.xcodeproj/project.pbxproj. I found that these values are generated fromswift generate-xcodeproj.To prevent inserting such absolute paths, added steps to replace absolute path with relative path after xcodeproj generation in Makefile.
My apologies for the mistake 🙇