Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment flag for BoringSSL/OpenSSL on MacOS #341

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Add environment flag for BoringSSL/OpenSSL on MacOS #341

merged 3 commits into from
Dec 10, 2018

Conversation

jgh-
Copy link
Contributor

@jgh- jgh- commented Dec 9, 2018

Sometimes one wants to use dependencies that rely on OpenSSL, and for those times updating build scripts is easier than forking projects.

This change adjusts the behavior of the OpenSSL vs BoringSSL selection in Package.swift. If you're not on Linux and the environment variable GRPC_USE_OPENSSL is present, it will use OpenSSL. If not it will use BoringSSL as usual.

Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks even better than before! I'll merge once the nit has been addressed.

Package.swift Outdated Show resolved Hide resolved
@MrMage
Copy link
Collaborator

MrMage commented Dec 10, 2018

Awesome, thanks!

@MrMage MrMage merged commit 54659b8 into grpc:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants