XCode 10.1 + Carthage support #360

byuarus · 2019-01-17T18:03:15Z

Tested with:

XCode 10.1 (Swift 4.2.1)
Carthage 0.31.2

Note:

Added scripts in pre-actions of the build action of SwiftGRPC-Package scheme of the SwiftGRPC-Carthage.xcodeproj:

cd ${PROJECT_DIR}
swift package resolve 
ruby fix-carthage-paths.rb SwiftGRPC-Carthage.xcodeproj

Script fix-carthage-paths.rb will fix paths to dependecies from ./build folder to match the paths in the SwiftGRPC-Carthage.xcodeproj file.

Updated patch-carthage-project.rb so you can re created the SwiftGRPC-Carthage.xcodeproj with make project-carthage

JonasVautherin

I tested it and it works for me. It stays in the same philosophy as the previous Carthage support, but this time it doesn't rely on an implementation detail of SwiftPM.

I had issues running the Pre-actions at first, because of swiftenv. But I believe it is a weird behavior not coming from this PR. I filed it here on the swiftenv repo.

Another solution may be to use XcodeGen instead of generating the xcodeproj through SwiftPM, but I did not manage to do it, so I would go for that in the meantime.

Note: it may not be compatible with Xcode 9, but that probably only means that people wanting it for Xcode 9 would have to use and older release, which I believe is acceptable.

Thanks a lot @byuarus for the work!

MrMage

Wow, thank you for this! It feels like a hack, and it sucks that we have to resort to this, but I guess that it’s the best way for a deterministically working Carthage support.

Looks good; just two nits. Also, are you (and or @JonasVautherin) willing to maintain this script in the future, in case it gets broken by future Swift or Carthage versions?

MrMage · 2019-01-22T11:19:49Z

fix-carthage-paths.rb

+        repoNameInXcodeproj = stringArray[0]
+
+        if !repoNameInXcodeproj.nil? and repoNameInXcodeproj.include? ".git-"
+


Nit: extra newline

MrMage · 2019-01-22T11:20:48Z

patch-carthage-project.rb


-swift_protobuf_target.new_shell_script_build_phase
+# 3) Adding to SwiftGRPC-Package.xcscheme a script to Pre-Actions of BuildAction.
+# Script will resolve SPM dependecies and will fix paths issues for SwiftGRPC-Carthage.xcodeproj before everytime before build action


nit: Could you fix the grammar of this sentence and explain that it fixes the issues by MOVING the existing files rather than changing the Xcode project?

JonasVautherin · 2019-01-22T13:22:57Z

Also, are you (and or @JonasVautherin) willing to maintain this script in the future, in case it gets broken by future Swift or Carthage versions?

The DronecodeSDK depends on grpc-swift, and supports Carthage. So we will be using that support for a while. Also, Carthage may support SwiftPM projects at some point 🤞

JonasVautherin

Trying the suggestion feature of Github :-)

fix-carthage-paths.rb

patch-carthage-project.rb

Co-Authored-By: byuarus <[email protected]>

byuarus · 2019-01-24T19:57:55Z

@JonasVautherin , thank you for the suggestions!

PS: Looks like the suggestion feature works :)

JonasVautherin · 2019-01-25T09:59:21Z

Just built again with the new commits, and that's still working!

MrMage

Thanks for this, I’m glad we now have a deterministic solution for Carthage!

Leaving the merge to @rebello95 or @timburks provided they approve as well :-)

JonasVautherin · 2019-01-31T10:29:26Z

Note: fixes #329.

* XCode 10 support * Fixed Carthage support * Carthage support WIP * Moved the fix-carthage-paths script to pre-build actions * Fixed patch-carthage-project script to support carthage * Fix carthage build * Changing SPM dependencies-state.json * Recreated SwiftGRPC-Carthage.xcodeproj file with updated script * More fixes for Carthage * Code clean up * Update patch-carthage-project.rb Co-Authored-By: byuarus <[email protected]> * Update fix-carthage-paths.rb Co-Authored-By: byuarus <[email protected]> * Update patch-carthage-project.rb Co-Authored-By: byuarus <[email protected]>

Renosi · 2019-03-21T17:39:08Z

I'm a newbie to working with Carthage and Github in general. I followed the steps outlined but I keep getting the error:

Building scheme "SwiftGRPC-Package" in SwiftGRPC-Carthage.xcodeproj
Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -project /Users/renosimomoh/Drone\ Delivery\ /Medical\ Drone/Carthage/Checkouts/grpc-swift/SwiftGRPC-Carthage.xcodeproj -scheme SwiftGRPC-Package -configuration Release -derivedDataPath /Users/renosimomoh/Library/Caches/org.carthage.CarthageKit/DerivedData/10.1_10B61/grpc-swift/b7659e1031b441da2db60fa879e8157799730f02 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/_s/vpqkvyq96rl9q9kj_b50w1s80000gn/T/grpc-swift SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO

How do I make sure that the recreatedSwiftGRPC-Carthage.xcodeprojis used when I run the Carthage update?

julianoes · 2019-03-22T07:43:54Z

@Renosi please create an issue in https://github.com/Dronecode/DronecodeSDK-Swift and paste all the output that you get in and quote the code with ```, thanks.

byuarus added 10 commits January 7, 2019 11:14

XCode 10 support

e1ad126

Fixed Carthage support

4214a4e

Carthage support WIP

c13866b

Moved the fix-carthage-paths script to pre-build actions

cfb8873

Fixed patch-carthage-project script to support carthage

0a58aec

Fix carthage build

8853cda

Changing SPM dependencies-state.json

a72c99c

Recreated SwiftGRPC-Carthage.xcodeproj file with updated script

83c3209

More fixes for Carthage

1998dd1

Code clean up

f6abc14

byuarus mentioned this pull request Jan 17, 2019

Using 3drobotics branch of grpc-swift mavlink/MAVSDK-Swift#105

Merged

JonasVautherin approved these changes Jan 17, 2019

View reviewed changes

MrMage reviewed Jan 22, 2019

View reviewed changes

JonasVautherin reviewed Jan 24, 2019

View reviewed changes

fix-carthage-paths.rb Outdated Show resolved Hide resolved

patch-carthage-project.rb Outdated Show resolved Hide resolved

patch-carthage-project.rb Outdated Show resolved Hide resolved

JonasVautherin and others added 3 commits January 24, 2019 11:55

Update patch-carthage-project.rb

b1fbf08

Co-Authored-By: byuarus <[email protected]>

Update fix-carthage-paths.rb

a37d36e

Co-Authored-By: byuarus <[email protected]>

Update patch-carthage-project.rb

b7659e1

Co-Authored-By: byuarus <[email protected]>

MrMage approved these changes Jan 29, 2019

View reviewed changes

MrMage merged commit 99d3834 into grpc:master Feb 14, 2019

MrMage mentioned this pull request Feb 14, 2019

Carthage not working for 0.5.1 & 0.6.0 #329

Closed

davidknezic mentioned this pull request Mar 25, 2019

Cannot build GRPC-Swift package in SwiftGRPC-Package.xcodeproj with Carthage mavlink/MAVSDK-Swift#114

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XCode 10.1 + Carthage support #360

XCode 10.1 + Carthage support #360

byuarus commented Jan 17, 2019

JonasVautherin left a comment

MrMage left a comment

MrMage Jan 22, 2019

MrMage Jan 22, 2019

JonasVautherin commented Jan 22, 2019

JonasVautherin left a comment

byuarus commented Jan 24, 2019

JonasVautherin commented Jan 25, 2019

MrMage left a comment

JonasVautherin commented Jan 31, 2019

Renosi commented Mar 21, 2019 •

edited

Loading

julianoes commented Mar 22, 2019

		repoNameInXcodeproj = stringArray[0]

		if !repoNameInXcodeproj.nil? and repoNameInXcodeproj.include? ".git-"

XCode 10.1 + Carthage support #360

XCode 10.1 + Carthage support #360

Conversation

byuarus commented Jan 17, 2019

JonasVautherin left a comment

Choose a reason for hiding this comment

MrMage left a comment

Choose a reason for hiding this comment

MrMage Jan 22, 2019

Choose a reason for hiding this comment

MrMage Jan 22, 2019

Choose a reason for hiding this comment

JonasVautherin commented Jan 22, 2019

JonasVautherin left a comment

Choose a reason for hiding this comment

byuarus commented Jan 24, 2019

JonasVautherin commented Jan 25, 2019

MrMage left a comment

Choose a reason for hiding this comment

JonasVautherin commented Jan 31, 2019

Renosi commented Mar 21, 2019 • edited Loading

julianoes commented Mar 22, 2019

Renosi commented Mar 21, 2019 •

edited

Loading