Update SwiftProtobuf to 1.3.1 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMage
reviewed
Feb 14, 2019
There was a problem hiding this comment.
Looks good to me, but any idea why echo.grpc.swift has changed to public visibility while removing the test stubs and the server-side code? That might also explain the CI failures. (You could try running make test-plugin; cp /tmp/echo.grpc.swift Sources/Examples/Echo/Generated/echo.grpc.swift to rebuild that file.)
This fixes several warnings with Xcode 10.2.
rebello95
force-pushed
the
update-swiftprotobuf
branch
from
00bd6c8 to
c35a409
Compare
|
Ah yea, good call @MrMage. Rebased + updated, let's see if CI passes now |
Update the generated code that's checked in for this example.
Ran `make project-carthage` and built the project to ensure it works correctly.
rebello95
force-pushed
the
update-swiftprotobuf
branch
from
c35a409 to
e32d64a
Compare
|
CI is green now |
MrMage
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits which are intended to merge separately:
makecommandEchoexample project using the updated plugins, which seemed to be very outdated. This whole directory needs to be cleaned up and validated, which I'll likely do in a follow-up PRTests I did:
.protofile, added the outputted files to the project, and built it