Update CocoaPods & Carthage for 0.8.0 release #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMage
approved these changes
Feb 18, 2019
|
Closing and re-opening to trigger a fresh CI run... |
|
CI is green now; @rebello95 I'd suggest you merge at your convenience and push the new release to CocoaPods afterwards. |
|
@rebello95 just a quick reminder that you can merge at your convenience :-) |
|
Yep, will do 😄 want to do some tests locally against master today/tomorrow beforehand |
|
:thumbs-up:
… On 21. Feb 2019, at 18:11, Michael Rebello ***@***.*** ***@***.***>> wrote:
Yep, will do 😄 want to do some tests against master today/tomorrow beforehand
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Will also update the Carthage project as part of this PR prior to merging, per #383 |
|
👍 Still LGTM. |
Updating prior to issuing a new release to include recent commits.
|
Rebased, re-generated carthage project, pushed. Will merge when CI is green. Built the Carthage project locally and ran the SwiftGRPC tests locally as well. |
rebello95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating prior to issuing a new release to include recent commits.