Make ConnectivityObserver class final #375
Conversation
This is `private` to the file and will never be subclassed. Also moved the setting of `underlyingCompletionQueue` inline to where it's declared.
| @@ -132,18 +132,17 @@ public class Channel { | |||
| } | |||
|
|
|||
| private extension Channel { | |||
| class ConnectivityObserver { | |||
| final class ConnectivityObserver { | |||
There was a problem hiding this comment.
Given that the containing extension is private already, making the class final won't make a difference to the compiler and it's unlikely that anyone is going to subclass ConnectivityObserver in the same file. However, it won't hurt, either.
There was a problem hiding this comment.
Agreed that this won't make a difference to the compiler, but I do think it's nice to annotate classes with final by default as opposed to making them subclass-able by default, since it is clearer from the reader's perspective whether something is currently being subclassed (since it could have another subclass elsewhere in the file in this particular example)
There was a problem hiding this comment.
That makes sense, thank you for explaining.
This is
privateto the file and will never be subclassed. I believe updating it with thefinalannotation will make this clearer to readers.