Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async client test stub methods #378

Merged

Conversation

cepages
Copy link

@cepages cepages commented Feb 24, 2019

This fixes #339

@cepages cepages changed the title I339 service test stub methods not implemented Service test stub methods not implemented Feb 24, 2019
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work! Some stylistic changes are needed.

Sources/SwiftGRPC/Core/CallResult.swift Outdated Show resolved Hide resolved
Sources/Examples/Echo/Generated/echo.grpc.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved
Sources/SwiftGRPC/Core/CallResult.swift Show resolved Hide resolved
Sources/Examples/Echo/Generated/echo.grpc.swift Outdated Show resolved Hide resolved
Sources/Examples/Echo/Generated/echo.grpc.swift Outdated Show resolved Hide resolved
Sources/SwiftGRPC/Core/CallResult.swift Outdated Show resolved Hide resolved
Sources/SwiftGRPC/Core/CallResult.swift Outdated Show resolved Hide resolved
Sources/Examples/Echo/Generated/echo.grpc.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved
Tests/SwiftGRPCTests/ClientTestExample.swift Outdated Show resolved Hide resolved

let completionHandlerExpectation = expectation(description: "request completion handler called")

_ = try client.service.get(Echo_EchoRequest(text: "foo")){ (response:Echo_EchoResponse?, callResult:CallResult) in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing spaces:

try client.service.get(Echo_EchoRequest(text: "foo")) { (response, callResult) in

Please try to adhere to how the rest of the project uses whitespace.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not resolved.

Sources/Examples/Echo/Generated/echo.grpc.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few more changes.

@MrMage
Copy link
Collaborator

MrMage commented Mar 5, 2019

@cepages I'm seeing your replies, but it looks like your fixes have not been pushed yet. Please let me know when I should re-review.

@cepages
Copy link
Author

cepages commented Mar 10, 2019

@MrMage All the comments have been pushed

@MrMage MrMage changed the title Service test stub methods not implemented Implement async client test stub methods Mar 21, 2019
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up the remaining issues myself.

@MrMage MrMage merged commit 630dfa5 into grpc:master Mar 21, 2019
@cepages cepages deleted the i339_ServiceTestStub_methods_not_implemented branch April 1, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceTestStub methods not implemented
3 participants