-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement async client test stub methods #378
Implement async client test stub methods #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work! Some stylistic changes are needed.
|
||
let completionHandlerExpectation = expectation(description: "request completion handler called") | ||
|
||
_ = try client.service.get(Echo_EchoRequest(text: "foo")){ (response:Echo_EchoResponse?, callResult:CallResult) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing spaces:
try client.service.get(Echo_EchoRequest(text: "foo")) { (response, callResult) in
Please try to adhere to how the rest of the project uses whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few more changes.
@cepages I'm seeing your replies, but it looks like your fixes have not been pushed yet. Please let me know when I should re-review. |
@MrMage All the comments have been pushed |
…f a real call object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up the remaining issues myself.
This fixes #339