Refactor some properties shared by all server-side call contexts into a common ServerCallContext protocol …
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a common `ServerCallContext` protocol, while renaming the existing `ServerCallContext` class to `ServerCallContextBase`. Motivation: As opposed to all three other call types, unary calls are not passed an instance of the previous `ServerCallContext` class, but rather of the `StatusOnlyCallContext` protocol. If one wanted to create a method that uses only a call's event loop and request headers but wants to process all *four* types of calls, that was not possible before. With this change, such a method could simply accept an instance of `ServerCallContext`, which the call arguments provided to all four methods now conform to.
|
@glbrntt, looks like I can't request a review from you, but please take a look regardless. |
rebello95
approved these changes
Mar 3, 2019
Sources/SwiftGRPCNIO/ServerCallContexts/UnaryResponseCallContext.swift
Outdated
Show resolved
Hide resolved
glbrntt
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… , while renaming the existing
ServerCallContextclass toServerCallContextBase.Motivation: As opposed to all three other call types, unary calls are not passed an instance of the previous
ServerCallContextclass, but rather of theStatusOnlyCallContextprotocol. If one wanted to create a method that uses only a call's event loop and request headers but wants to process all four types of calls, that was not possible before. With this change, such a method could simply accept an instance ofServerCallContext, which the call arguments provided to all four methods now conform to.