Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable NIOClientTimeoutTests.testBidirectionalStreamingTimeoutAfterSending on Linux for now #409

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

MrMage
Copy link
Collaborator

@MrMage MrMage commented Mar 21, 2019

This test tends to crash randomly on Linux (making CI flaky), so it is disabled there for now.

Most of the NIO work is done on the nio branch now, anyway, where this test is still being run.

…TimeoutAfterSending` on Linux for now

This test tends to crash randomly on Linux (making CI flaky), so it is disabled there for now.

Most of the NIO work is done on the `nio` branch now, anyway, where this test is still being run.
@MrMage MrMage requested a review from rebello95 March 21, 2019 09:15
@glbrntt
Copy link
Collaborator

glbrntt commented Mar 21, 2019

@MrMage can you create an issue to fix this?

@MrMage
Copy link
Collaborator Author

MrMage commented Mar 21, 2019

@MrMage can you create an issue to fix this?

@glbrntt I'm not even sure if it's still occurring with the non-nghttp2 variant of SwiftNIO at all; let's keep monitoring commits to that branch for CI failures.

@glbrntt
Copy link
Collaborator

glbrntt commented Mar 21, 2019

Okay, that's fine with me!

@MrMage
Copy link
Collaborator Author

MrMage commented Mar 21, 2019

Looks like this CI failure is to temporary unavailability of Homebrew, as evidenced by the fact that one of the two CI builds succeeded. I think this can be reviewed anyway.

@MrMage MrMage merged commit 4df501a into master Mar 21, 2019
@MrMage MrMage deleted the MrMage-patch-1 branch March 21, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants