Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on both Swift 4.2 and 5, and fix Swift 5 warning #426

Merged
merged 7 commits into from
Apr 16, 2019
Merged

Run CI on both Swift 4.2 and 5, and fix Swift 5 warning #426

merged 7 commits into from
Apr 16, 2019

Conversation

rebello95
Copy link
Collaborator

@rebello95 rebello95 commented Apr 11, 2019 •
edited
Loading

Fixes a warning when compiling with Swift 5:

'withUnsafeBytes' is deprecated: use `withUnsafeBytes(…)

Also updates CI to run tests on both Swift 4.2 and Swift 5.0.

@rebello95
Fix Swift 5 warning for UnsafeMutableRawPointer
893a0da 
Fixes a warning when compiling with Swift 5:

> 'withUnsafeBytes' is deprecated: use `withUnsafeBytes<R>(…)
@rebello95 rebello95 requested review from timburks and MrMage April 11, 2019 17:19
timburks
timburks previously requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timburks timburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to update CI to use Swift 5:

grpc-swift/.travis-install.sh

Line 35 in ece94e8

SWIFT_URL=https://swift.org/builds/swift-4.1.1-release/ubuntu1404/swift-4.1.1-RELEASE/swift-4.1.1-RELEASE-ubuntu14.04.tar.gz

@rebello95
Copy link
Collaborator Author

Updated @timburks - we'll see if CI takes the change. @MrMage would also appreciate it if you could take a look whenever you get a chance 😃

MrMage
MrMage requested changes Apr 12, 2019
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
.travis-install.sh Show resolved Hide resolved
@rebello95
Copy link
Collaborator Author

Looks like a CI flake, re-running

@rebello95 rebello95 closed this Apr 15, 2019
@rebello95 rebello95 reopened this Apr 15, 2019
@rebello95 rebello95 changed the title Fix Swift 5 warning for UnsafeMutableRawPointer Run CI on both Swift 4.2 and 5, and fix Swift 5 warning Apr 15, 2019
@rebello95
Copy link
Collaborator Author

Thanks for the feedback @MrMage @timburks @keith! 🙏

CI is green now, and ran on 4.2 and 5.0.

@rebello95 rebello95 requested review from MrMage and timburks April 15, 2019 18:04
MrMage
MrMage approved these changes Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor remarks.

Also, if we now run twice as many CI jobs, flakes might occur more frequently. If that is the case, we might want to pay more attention to them.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@rebello95 rebello95 dismissed timburks’s stale review April 16, 2019 16:33

Comments addressed, Daniel approved

@rebello95
Copy link
Collaborator Author

Sounds good. Going to go ahead and merge.

@rebello95 rebello95 merged commit 0f2af51 into grpc:master Apr 16, 2019
@rebello95 rebello95 deleted the swift5-warning branch April 16, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith left review comments

@MrMage MrMage MrMage approved these changes

@timburks timburks Awaiting requested review from timburks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rebello95 @timburks @MrMage @keith