Add the connection backoff interop test #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We'd like our implementation to be compliant with the gRPC specification. Passing the interop tests is an important part of this, yet we don't have an implementation of the connectivity backoff test. Modifications: - Implement the connectivity backoff test. - Fixes a bug where call timeouts would not be respected if the connection had not been established. - Fixes a bug where the connection could be re-established after calling shutdown. Result: Our connection backoff code has better test coverage; fewer bugs.
MrMage
approved these changes
Aug 20, 2019
|
We should yes, I was going to set up the CI to run all interop tests against a different implementation (probably C++ since it's recommended for the backoff test). I'll look into this and post a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We'd like our implementation to be compliant with the gRPC
specification. Passing the interop tests is an important part of this,
yet we don't have an implementation of the connectivity backoff test.
Modifications:
connection had not been established.
shutdown.
Result:
Our connection backoff code has better test coverage; fewer bugs.