Fix license header check #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The license header script silently stopped working when we let it find all issues before exiting. Modifications: - Fix script - Fix bad indentation in header Result: Licnese checking works again.
Lukasa
approved these changes
Jul 22, 2020
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Aug 3, 2020
Motivation: The "gRPC-Core" cocoapod specifies its module name as "grpc"; this is unfortunate because we also specify our module name as "GRPC". This is problematic of both are used in the same dependency graph. In CocoaPods `module_name` is "name to use for the framework / clang module which will be generated". We therefore end up with two "GRPC" frameworks. If the module name is not specified it will default to the spec name instead. Modifications: - Don't generate a custom module name when generating Podspecs - Delete trailing whitespace Result: - Resolves grpc#905 - Generated frameworks match Podspec names (i.e. "gRPC-Swift" gets converted to "gRPC_Swift")
glbrntt
added a commit
that referenced
this pull request
Aug 3, 2020
Motivation: The "gRPC-Core" cocoapod specifies its module name as "grpc"; this is unfortunate because we also specify our module name as "GRPC". This is problematic of both are used in the same dependency graph. In CocoaPods `module_name` is "name to use for the framework / clang module which will be generated". We therefore end up with two "GRPC" frameworks. If the module name is not specified it will default to the spec name instead. Modifications: - Don't generate a custom module name when generating Podspecs - Delete trailing whitespace Result: - Resolves #905 - Generated frameworks match Podspec names (i.e. "gRPC-Swift" gets converted to "gRPC_Swift")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The license header script silently stopped working when we let it find
all issues before exiting.
Modifications:
Result:
Licnese checking works again.