Reduce code duplication between builders and configuration #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The client and server builders each eventually produce a `Configuration`. Each `Configuration` has a bunch of defaults which were duplicated in the builder. Modifications: - Builders use configuration rather than relying on their own values and then building a configuration Result: - Less code duplication; lower chance of drift in defaults between configuration and builders
Lukasa
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The client and server builders each eventually produce a
Configuration.Each
Configurationhas a bunch of defaults which were duplicatedin the builder.
Modifications:
then building a configuration
Result:
configuration and builders