Add a server debug channel initializer #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Jul 27, 2020
Sources/GRPC/Server.swift
Outdated
| /// This may be used to add additional handlers to the pipeline and is intended for debugging. | ||
| /// This is analogous to `NIO.ServerBootstrap.childChannelInitializer`. | ||
| /// | ||
| /// - Warning: The initializer closure may be invoked *multiple times*. |
There was a problem hiding this comment.
Strictly this one is invoked no more than once per connection.
There was a problem hiding this comment.
Good point; I added clarification.
Sources/GRPC/ServerBuilder.swift
Outdated
| /// This may be used to add additional handlers to the pipeline and is intended for debugging. | ||
| /// This is analogous to `NIO.ServerBootstrap.childChannelInitializer`. | ||
| /// | ||
| /// - Warning: The initializer closure may be invoked *multiple times*. |
Motivation: Sometimes it's helpful to be able to add additional handlers to the channel pipeline. We let clients to do this, so we should let servers do it too. Modifications: - Add a `debugChannelInitializer` to server configuration and the server builder Result: - Users can add additional channel handlers to servers
glbrntt
force-pushed
the
gb-debug-init-server
branch
from
7a32b51 to
e2204a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes it's helpful to be able to add additional handlers to the
channel pipeline. We let clients to do this, so we should let servers do
it too.
Modifications:
debugChannelInitializerto server configuration and the serverbuilder
Result: