Mitigate zero-length writes issue. #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Aug 4, 2020
|
|
||
| func noZeroLengthWriteExpectation() -> XCTestExpectation { | ||
| let expectation = self.expectation(description: "Not expecting zero length write workaround") | ||
| expectation.isInverted = true |
There was a problem hiding this comment.
Rather than inverting the expectation, can we fulfil our expectation when we see the error from not finding the handler instead?
There was a problem hiding this comment.
We can do, but it breaks the test symmetry: I have to write two test flows instead. Is that your preference?
There was a problem hiding this comment.
Why two test flows? Couldn't we just pass two (Result<NIOFilterEmptyWritesHandler, Error>) -> Void closures through to _runTest and debugPipelineExpectation and run them run in an always block rather than passing through the expectation?
There was a problem hiding this comment.
Oh, yeah, we can do that. It's a bit less clean at the test site, but works fine.
Motivation: On some iOS releases, zero-length writes cause problems for Network.framework. These problems can lead to difficult to debug catastrophic failure modes, so they ought to be avoided. NIOTransportServices provides a workaround channel handler, which we ought to use. Modifications: - Add a PlatformSupport check for whether to apply the workaround. - Add the workaround code to the pipeline configuration callbacks. - Tests Results: Users can work around the zero length writes problem.
Lukasa
force-pushed
the
cb-zero-length-writes
branch
from
4fe97e8 to
cbc422e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On some iOS releases, zero-length writes cause problems for
Network.framework. These problems can lead to difficult to debug
catastrophic failure modes, so they ought to be avoided.
NIOTransportServices provides a workaround channel handler, which we
ought to use.
Modifications:
Results:
Users can work around the zero length writes problem.