Switch a numericCast to the required type
#920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The server codec uses `numericCast` to turn an `Int` into `_Capacity` in order to call `ByteBuffer.clear(minimumCapacity:)` which accidentally requires an underscore-internal type for capacity. The as yet unreleased fix in NIO deprecates that function and adds an identical signature using `Int` instead of `_Capacity`. Using `numericCast` in this instance will result in a compiler error since the type is ambiguous. Modifications: - Replace the `numericCast` with `UInt32`, the alias of `_Capacity`. Result: - When the NIO fix is released, gRPC will still be able to compile.
Lukasa
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The server codec uses
numericCastto turn anIntinto_Capacityinorder to call
ByteBuffer.clear(minimumCapacity:)which accidentallyrequires an underscore-internal type for capacity. The as yet unreleased
fix in NIO deprecates that function and adds an identical signature
using
Intinstead of_Capacity.Using
numericCastin this instance will result in a compiler errorsince the type is ambiguous.
Modifications:
numericCastwithUInt32, the alias of_Capacity.Result: