Tolerate idling from the active state #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In certain conditions it's possible for a connection to idle when in the 'active' state resulting in a precondition failure. The active state is not user facing and represents the state where we have an active connection to a remote peer but have not yet seen the initial settings frame. It's not usually possible for users to get a connection in this state since we normally only vend connections in the 'ready' state (where we have seen the initial settings frame). However, in the 'fastFailure' mode this constraint is lifted. If keepalive is configured, the connection is in the active state, and the client starts an RPC then it is possible for the keepalive timeout to fire, idling the connection before it reaches the ready state, resulting in a precondition failure. Modifications: - Allow the connection manager to idle from the active state Result: - Idling from the active state is tolerated - Resolves grpc#949
Lukasa
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In certain conditions it's possible for a connection to idle when in the
'active' state resulting in a precondition failure.
The active state is not user facing and represents the state where we
have an active connection to a remote peer but have not yet seen the
initial settings frame. It's not usually possible for users to get a
connection in this state since we normally only vend connections in the
'ready' state (where we have seen the initial settings frame). However,
in the 'fastFailure' mode this constraint is lifted.
If keepalive is configured, the connection is in the active state, and
the client starts an RPC then it is possible for the keepalive timeout
to fire, idling the connection before it reaches the ready state,
resulting in a precondition failure.
Modifications:
Result: