Move idle handler state to closed on channelInactive #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Aug 25, 2020
Motivation: Related to grpc#949. It's possible for the client's connection to be dropped, and for the connection state to become idle, prior to the scheduled close from the keepalive handler firing. As the idle handler never updates its state to 'closed' in 'channelInactive', when the scheduled close event is picked up in the idle handler it effectively ask the connection manager to double-idle, hitting a precondition failure. Modifications: - Move the 'GRPCIdleHandler' to '.closed' in 'channelInactive' - Cancel scheduled pings and timeouts on 'channelInactive' in the 'GRPCKeepaliveHandlers' Result: - We avoid another path to a precondition failure
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Related to #949.
It's possible for the client's connection to be dropped, and for the
connection state to become idle, prior to the scheduled close from the
keepalive handler firing. As the idle handler never updates its state to
'closed' in 'channelInactive', when the scheduled close event is picked
up in the idle handler it effectively ask the connection manager to
double-idle, hitting a precondition failure.
Modifications:
'GRPCKeepaliveHandlers'
Result: