Increase the client idle timeout, remove the default server idle timeout #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Sep 17, 2020
Motivation: We usually follow the gRPC core library for default values for various configuration settings. However, the gRPC core library documentation around connection idle timeouts is inconsistent at best. It suggests that both client and server will idle connections after 5 minutes (by default). Other documentation suggests that the client will idle connections after 30 minutes by default and that the server will never shed idle connections by default. The code in gRPC core library mostly agrees with these values. The exception is for the client where an as yet unresolved bug has led to the client idle timeout being disabled by default. Modifications: - Increase the default client idle timeout to 30 minutes - Change the server default idle timeout to indefinite Result: Our default configuration is closer to the gRPC core lib.
glbrntt
force-pushed
the
gb-default-idle-timeouts
branch
from
205132c to
f236a68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We usually follow the gRPC core library for default values for various
configuration settings. However, the gRPC core library documentation
around connection idle timeouts is inconsistent at best. It suggests
that both client and server will idle connections after 5 minutes (by
default).
Other documentation suggests that the client will idle connections after
30 minutes by default and that the server will never shed idle
connections by default. The code in gRPC core library mostly agrees with
these values. The exception is for the client where an as yet unresolved
bug has led to the client idle timeout being disabled by default.
Modifications:
Result:
Our default configuration is closer to the gRPC core lib.