Add an option to set 'certificateVerification' to the client builder #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Sep 30, 2020
|
Worth adding a test for this? |
Motivation: We allow users to set the `certificateVerification` if they configure their client directly using `ClientConnection.Configuration` but not via the builder API. Modifications: - Add `withTLS(certificateVerification:)` to the client connection builder. (The same option is already available on the server builder) Result: Users can set the certificate verification mode on the client builder.
glbrntt
force-pushed
the
gb-cert-verification-option
branch
from
221404b to
c3a1915
Compare
Done. I was just being lazy 🙈 |
Lukasa
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We allow users to set the
certificateVerificationif they configuretheir client directly using
ClientConnection.Configurationbut not viathe builder API.
Modifications:
withTLS(certificateVerification:)to the client connection builder.(The same option is already available on the server builder)
Result:
Users can set the certificate verification mode on the client builder.