Pin formatter #995
Merged
Pin formatter #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We added SwiftFormat as part our CI to in order to keep formatting consistent. However, new rules are often introduced and new behaviours are added and the formatting can change quite significantly as a result. In order to get stable formatting we need to pin the version we use or include the tool as part of the project. This is somewhat annoying: in the first case it requires the user to get the right version, in the second case we add a depdendency which isn't required to consume the library, that's a little silly! We can make the first case a little nicer by providing a script to build the right version from source. Modifications: - Add scripts/format.sh which builds a predefined version of SwiftFormat and runs it - Pin the version in .travis-install.sh to the same as in format.sh Result: - SwiftFormat is pinned to a version
Lukasa
approved these changes
Oct 15, 2020
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Oct 19, 2020
Motivation: We added SwiftFormat as part our CI to in order to keep formatting consistent. However, new rules are often introduced and new behaviours are added and the formatting can change quite significantly as a result. In order to get stable formatting we need to pin the version we use or include the tool as part of the project. This is somewhat annoying: in the first case it requires the user to get the right version, in the second case we add a depdendency which isn't required to consume the library, that's a little silly! We can make the first case a little nicer by providing a script to build the right version from source. Modifications: - Add scripts/format.sh which builds a predefined version of SwiftFormat and runs it - Pin the version in .travis-install.sh to the same as in format.sh Result: - SwiftFormat is pinned to a version (cherry picked from commit cdb46f4)
glbrntt
added a commit
that referenced
this pull request
Oct 19, 2020
Motivation: We added SwiftFormat as part our CI to in order to keep formatting consistent. However, new rules are often introduced and new behaviours are added and the formatting can change quite significantly as a result. In order to get stable formatting we need to pin the version we use or include the tool as part of the project. This is somewhat annoying: in the first case it requires the user to get the right version, in the second case we add a depdendency which isn't required to consume the library, that's a little silly! We can make the first case a little nicer by providing a script to build the right version from source. Modifications: - Add scripts/format.sh which builds a predefined version of SwiftFormat and runs it - Pin the version in .travis-install.sh to the same as in format.sh Result: - SwiftFormat is pinned to a version (cherry picked from commit cdb46f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We added SwiftFormat as part our CI to in order to keep formatting
consistent. However, new rules are often introduced and new behaviours
are added and the formatting can change quite significantly as a result.
In order to get stable formatting we need to pin the version we use or
include the tool as part of the project. This is somewhat annoying: in
the first case it requires the user to get the right version, in the
second case we add a depdendency which isn't required to consume the
library, that's a little silly! We can make the first case a little
nicer by providing a script to build the right version from source.
Modifications:
and runs it
Result: