Fix issue where no RPC is issued when deadline
is specified.
#1172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
This is a temporary hack to fix #1153, which is caused by
goog.global
not properly pointing to the proper global scope (e.g.window
) when grpc-web is being imported as a CommonJS module (becausethis
points to the module scope instead of actual global scope (i.e.globalThis
)).goog.Timer.defaultTimerObject
is set to point togoog.global
, and that's why it throws whensetTimeout
is called on it.The fix
globalThis
when possible, and if it's not available (pre-2020 browsers, etc.), fallback toself
, which should work in both browsers and workers.