Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actions (workflows) for building protoc-gen-grpc-web plugins #1203

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Github Actions (workflows) for building protoc-gen-grpc-web plugins #1203

merged 1 commit into from
Feb 18, 2022

Conversation

sampajano
Copy link
Collaborator

Summary

For Linux, MacOS, and Windows:

  • Added new Github Actions (Workflow) for building the protoc-gen-grpc-web plugin to be used for releases.
  • Workflow can be manually triggered with a version_number param (part of binary name)
  • sha256 checksum are also generated and verified (except Windows)
  • Plugin binary and sha256 are uploaded for manual download

Platform specifics

  • Linux - plugin built using Docker
  • MacOS - plugin built using Makefile
    • Protobuf installed using make install from git submodule
  • Windows - plugin built using Bazel

@sampajano sampajano changed the title Add Github Actions (workflows) for building grpc-web protoc plugins (Linux, MacOS, and Windows) Github Actions (workflows) for building grpc-web protoc plugins (Linux, MacOS, and Windows) Feb 9, 2022
@sampajano sampajano changed the title Github Actions (workflows) for building grpc-web protoc plugins (Linux, MacOS, and Windows) Github Actions (workflows) for building grpc-web protoc plugins Feb 9, 2022
@sampajano sampajano changed the title Github Actions (workflows) for building grpc-web protoc plugins Github Actions (workflows) for building protoc-gen-grpc-web plugins Feb 9, 2022
stanley-cheung
stanley-cheung approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Thanks!

@sampajano sampajano merged commit 3102383 into grpc:master Feb 18, 2022
@sampajano sampajano deleted the 1-github-actions branch April 21, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampajano @stanley-cheung