Update ES6 imports with comment about corresponding proto import path. #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks like I need to fix it up to get the build working :) |
aha yes. I'll rerun the test after you've pushed a new version. thanks! |
gonzojive
force-pushed
the
proto-import-comment
branch
from
3672778 to
63d8bea
Compare
I was experiencing a long import path in the generated code that doesn't work. Outputting the proto file that corresponds to a JS import is helpful for both diagnosing the issue and writing a wrapper for altering the import path to my satisfaction. Before: ```js import * as github_com_gonzojive_rules_ts_proto_example_prefix_greeting_pb from '../../../../../github.com/gonzojive/rules_ts_proto/example/prefix/greeting_pb'; ``` After: ```js import * as github_com_gonzojive_rules_ts_proto_example_prefix_greeting_pb from '../../../../../github.com/gonzojive/rules_ts_proto/example/prefix/greeting_pb'; // proto import: "github.com/gonzojive/rules_ts_proto/example/prefix/greeting.proto" ```
gonzojive
force-pushed
the
proto-import-comment
branch
from
64b1859 to
81b1569
Compare
I believe the issue is fixed now. TFTR |
Great! The tests are passing now! Thanks so much for the change! 😃 |
gonzojive
added a commit
to gonzojive/grpc-web
that referenced
this pull request
Apr 15, 2023
…t path. grpc#1313 updated the code generator to print a "proto import: "foo/bar.proto" suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.
gonzojive
added a commit
to gonzojive/grpc-web
that referenced
this pull request
Apr 15, 2023
…t path. grpc#1313 updated the code generator to print a "proto import: "foo/bar.proto" suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.
gonzojive
added a commit
to gonzojive/grpc-web
that referenced
this pull request
Apr 15, 2023
…t path. grpc#1313 updated the code generator to print a `proto import: "foo/bar.proto"` suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.
gonzojive
added a commit
to gonzojive/grpc-web
that referenced
this pull request
Oct 2, 2023
Followup to grpc#1313 for .d.ts files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1311, which I created with my non-corporate account. I can use the corporate account to meet the CLA requirement.
I was experiencing a long import path in the generated code that doesn't work. Outputting the proto file that corresponds to a JS import is helpful for both diagnosing the issue and writing a wrapper for altering the import path to my satisfaction.
Before:
After: