Update to use @grpc/grpc-js node package, and update helloworld example #852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 1.0 release of
@grpc/grpc-js
and the announcement that the originalgrpc
node package will not receive new features, let's update our usage to the@grpc/grpc-js
package.In the process, I made some cleanups to the helloworld example.
server.js
needs to usebindAsync
instead ofbind
helloworld.proto
here, which arguably, we should not.)envoy.Dockerfile
. We can just run the standard Envoy image and pass in our customenvoy.yaml
.