Add scripts to run interop-tests on grpc-web Java connector #869
Conversation
scripts/run_java_interop_tests.sh
Outdated
| sleep 15 | ||
|
|
||
| # Run interop tests | ||
| docker run --network=host --rm grpcweb/prereqs /bin/bash /github/grpc-web/scripts/docker-run-interop-tests.sh |
There was a problem hiding this comment.
This is nice you can run exactly the same interop client!!
scripts/run_java_interop_tests.sh
Outdated
| docker run --network=host --rm grpcweb/prereqs /bin/bash /github/grpc-web/scripts/docker-run-interop-tests.sh | ||
|
|
||
| docker rm -f "$pid" | ||
|
|
There was a problem hiding this comment.
Can you put L42 - L49 above in here: https://github.com/grpc/grpc-web/blob/master/scripts/run_interop_tests.sh#L49
Then you don't need this run_java_interop_tests.sh script.
You can merge your L43 above with https://github.com/grpc/grpc-web/blob/master/scripts/run_interop_tests.sh#L34
There was a problem hiding this comment.
good idea!
done.
PTAL
scripts/run_interop_tests.sh
Outdated
| # | ||
| # Run interop tests against grpc-web java connector code | ||
| # | ||
| docker-compose build java-interop-server |
There was a problem hiding this comment.
Nit: can we merge this line with L34 above? So we build all the docker images first.
scripts/run_interop_tests.sh
Outdated
| # | ||
| docker-compose build java-interop-server | ||
| pid3=$(docker run -d --network=host grpcweb/java-interop-server) | ||
| docker run --network=host --rm grpcweb/prereqs /bin/bash /github/grpc-web/scripts/docker-run-interop-tests.sh |
There was a problem hiding this comment.
Nit: can we break this long line like L43-44 above? Just to be consistent.
Thanks
There was a problem hiding this comment.
done. (made a shell function to call tests)
|
Thanks for the reviews. PTAL |
Thanks! Looks good. One final nit: can you please squash this down to maybe 1 commit please? |
vnorigoog
force-pushed
the
interop-testing-automation-java
branch
from
7f53bcb to
1b62cce
Compare
stanley-cheung
changed the title
No description provided.