-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust column width for main documentation text #186
Conversation
Signed-off-by: lucperkins <[email protected]>
In this that there is another root cause to the problem being reported in #185. |
Or maybe we just need to tweak the breakpoints. |
@@ -8,7 +8,7 @@ | |||
{{ partial "nav.html" . }} | |||
</div> | |||
|
|||
<div class="column"> | |||
<div class="column is-three-quarters"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want this to be 3/4s only when the left nav is showing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column system uses Flexbox to automatically expand and contract these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: lucperkins <[email protected]>
@chalin I think there's a browser-specific issue at work because this works fine for me on macOS/Firefox. I added a PostCSS pipeline that might help. |
I see the same problems (the original problem and the issue with the #186 fix) under macOS 10.14.6 and FF 75.0. |
@chalin Unfortunately, eliminating all issues on all browsers and screen sizes is incredibly time intensive. Please feel free to follow up on this work if desired. |
To be clear: I agree that |
Here is the followup issue: #188. |
Closes #188 Revert change discussed in #186 (comment)
Closes #188 Revert change discussed in #186 (comment)
Fixes #185