Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust column width for main documentation text #186

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Adjust column width for main documentation text #186

merged 2 commits into from
Apr 13, 2020

Conversation

lucperkins
Copy link
Contributor

Fixes #185

Signed-off-by: lucperkins <[email protected]>
@lucperkins lucperkins requested a review from chalin April 13, 2020 20:45
@chalin
Copy link
Collaborator

chalin commented Apr 13, 2020

In this that there is another root cause to the problem being reported in #185.

@chalin
Copy link
Collaborator

chalin commented Apr 13, 2020

Looking at the Java QS at 770 px width, this is what I see, which is probably not the result we want:

Screen Shot 2020-04-13 at 17 06 19

@chalin
Copy link
Collaborator

chalin commented Apr 13, 2020

Or maybe we just need to tweak the breakpoints.

@@ -8,7 +8,7 @@
{{ partial "nav.html" . }}
</div>

<div class="column">
<div class="column is-three-quarters">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want this to be 3/4s only when the left nav is showing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column system uses Flexbox to automatically expand and contract these.

Copy link
Collaborator

@chalin chalin Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this change leads to the problem I mentioned at the start of this thread, see #128

I'll revert this specific change, reopen #185 and submit a fix.

Signed-off-by: lucperkins <[email protected]>
@lucperkins
Copy link
Contributor Author

@chalin I think there's a browser-specific issue at work because this works fine for me on macOS/Firefox. I added a PostCSS pipeline that might help.

@chalin
Copy link
Collaborator

chalin commented Apr 13, 2020

I see the same problems (the original problem and the issue with the #186 fix) under macOS 10.14.6 and FF 75.0.

@lucperkins
Copy link
Contributor Author

@chalin Unfortunately, eliminating all issues on all browsers and screen sizes is incredibly time intensive. Please feel free to follow up on this work if desired.

@chalin
Copy link
Collaborator

chalin commented Apr 13, 2020

To be clear: I agree that is-three-quarters seemed to be missing, but there is a separate issue with breakpoints mismatching on the left-nav collapse and the adjustment of the column width. But I agree with you that we can address that separately.

@chalin chalin merged commit 566f93f into grpc:master Apr 13, 2020
@lucperkins lucperkins deleted the lperkins/text-crop-issue branch April 13, 2020 21:59
@chalin
Copy link
Collaborator

chalin commented Apr 14, 2020

Here is the followup issue: #188.

chalin added a commit that referenced this pull request Oct 16, 2020
Closes #188

Revert change discussed in #186 (comment)
chalin added a commit that referenced this pull request Oct 16, 2020
Closes #188

Revert change discussed in #186 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code snippets overextend layout on narrow browser windows
2 participants