Fix compilation with PORTABLE symbol. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling with the PORTABLE symbol results in several errors. > The namespace 'TinyIoC' already contains a definition for > 'ReverseTypeExtender' The NETSTANDARD1_6 symbol is OR'd instead of AND'd. Since the rest of the symbols are AND'd, this appears to be a copy-and-paste error. > Inconsistent accessibility: parameter type 'BindingFlags' is less > accessible than method 'TypeExtensions.GetConstructors(Type, > BindingFlags)' The BindingFlags enum is marked internal; however, it is included in various public method signatures.
|
I just made this change manually as well is this project dead? :( |
|
Updated this change manually in my project as well. Those 2 issues blocks PCL integration in the first step :( |
|
Thanks for the PR. |
gkarabin
pushed a commit
to gkarabin/TinyIoC
that referenced
this pull request
Apr 16, 2020
Fix compilation with PORTABLE symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling with the PORTABLE symbol results in several errors.
The NETSTANDARD1_6 symbol is OR'd instead of AND'd. Since the rest of
the symbols are AND'd, this appears to be a copy-and-paste error.
The BindingFlags enum is marked internal; however, it is included in
various public method signatures.