Fix protected ctor resolution regression #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to exercise construction and checking resolution of classes that have only protected constructors. A new test that asserts that CanResolve of a class with only a protected constructor will return false will fail. The regression was introduced in grumpydev@3891ab9. The original use of type.GetConstructors() only returend public constructors - no protected ones. Resolution of a protected constructor must throw and checking for resolution must also fail. On the other hand, resolving a concrete subclass of such a class should succeed if the subclass has a public constructor that has its dependencies met.
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working with an older commit of TinyIoC in one of my projects. Updating to the latest master commit I ran into a regression with CanResolve on a class with a protected constructor.
I rely on CanResolve returning false on a base class with only protected constructors, so that I know that the consumer of my library has not registered an implementation of that base class, letting me provide my default implementation.
That behavior changed here: 3891ab9 - the original use of Type.GetConstructors did not return protected constructors, but the new implementation did.
This fix filters out protected constructors from the set that allows CanResolve to return true.