Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation of memory usage. Reduced allocations of objects. #152

Merged
merged 1 commit into from Jul 2, 2021
Merged

Optimisation of memory usage. Reduced allocations of objects. #152

merged 1 commit into from Jul 2, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2021

No description provided.

@niemyjski
Copy link
Collaborator

@AlexanderMy Thanks for submitting the PR, can you share any benchmarks vs the baseline you ran against. We have some benchmarks setup in a benchmark project in this repo.

if (registrationPredicate != null)
private bool IsIgnoredType(Type type, Func<Type, bool> registrationPredicate)
{
if (registrationPredicate != null && !registrationPredicate(type))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be stored in a temp variable and added to the ignore checks below (saved an extra lookup)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done as you said or am I missing something?

@ghost
Copy link
Author

ghost commented Jun 22, 2021

@AlexanderMy Thanks for submitting the PR, can you share any benchmarks vs the baseline you ran against. We have some benchmarks setup in a benchmark project in this repo.

Please find my results:
Screenshot 2021-06-22 at 17 25 01

@niemyjski niemyjski merged commit 9a4b579 into grumpydev:master Jul 2, 2021
@niemyjski
Copy link
Collaborator

Thanks for the PR! Let me know if you need a release out there soon?

@ghost
Copy link
Author

ghost commented Jul 2, 2021

Thanks for the PR! Let me know if you need a release out there soon?

Thanks for merging. We don't need the release just now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant